December 31, 2010

Ashwin Das Ashwin Das
Lab Rat
33 posts

Suggestion in Qt Creator content assist for QScopedPointer

Page  
1

I have a suggestion to Qt creator – [I am currently using Qt Creator 2.0.94 (2.1.0-rc1)—]

When I am coding with pointers like for eg –

  1.  QGridLayout* layout = new QGridLayout();

later after this if I type layout followed by a dot .. it changes to layout-> automatically and shows a content assist with the avialable functions and variables etc., making my life easy.

But when I am using a QScopePointer like –

  1. QScopedPointer<QTableView> table(new QTableView);

and now to get the content assist for functions in the QTableView, I have to manually enter both – and > like table->, which requires 3 key press, – followed by Shift + . (>)

This is not a major concern but is slightly irritating. Most of the time we will be working on methods in QTableView and use function like reset and others in QScopePointer in a relatively smaller percent. So having to remember to type -,> every time is a bit annoying.

So can this be changed and made such that a dot following a QScopePointer behaves in a similar way to normal pointer.

This is also the case with other such classes like QSharedPointer and QPointer etc..
and I type table followed by dot, it shows the functions available from the QScopedPointer

26 replies

December 31, 2010

Zlatomir Zlatomir
Hobby Entomologist
366 posts

I’m somehow against this, and the same behavior for “normal” pointers, this increase the confusion some people have between a pointer and an object, and writing the “arrow” operator it’s not the end of the world… that is what we do, we write code ;)

And another issue is how do you call reset(…) member function for your scoped pointer after Trolls make Creator replace . automatically with ->?

December 31, 2010

ixSci ixSci
Lab Rat
206 posts

Ashwin Das, if you use smart pointers overloaded operator -> more often then . doesn’t mean others use it as you do.

January 1, 2011

Panke Panke
Lab Rat
42 posts
Zlatomir wrote:
And another issue is how do you call reset(…) member function for your scoped pointer after Trolls make Creator replace . automatically with ->?

That’s the point.

January 1, 2011

Ashwin Das Ashwin Das
Lab Rat
33 posts

Zlatomir wrote:
I’m somehow against this, and the same behavior for “normal” pointers, this increase the confusion some people have between a pointer and an object, and writing the “arrow” operator it’s not the end of the world… that is what we do, we write code ;)

And another issue is how do you call reset(…) member function for your scoped pointer after Trolls make Creator replace . automatically with ->?

Yes that makes sense, so it can be such that when I type -, the -> comes up. Which would be easier. Now it is bit complicated. I want it to be easier.

ixSci wrote:
Ashwin Das, if you use smart pointers overloaded operator -> more often then . doesn’t mean others use it as you do.

ixSci, even others uses -> more often as I do

January 1, 2011

ixSci ixSci
Lab Rat
206 posts

ixSci, even others uses -> more often as I do

Why are you so sure about it? Can you present some evidence about it? because at least I don’t use it more often.

January 1, 2011

Ashwin Das Ashwin Das
Lab Rat
33 posts
ixSci wrote:
ixSci, even others uses -> more often as I do
Why are you so sure about it? Can you present some evidence about it? because at least I don’t use it more often.

Eg: When using

  1. QScopedPointer<QTableView> table(new QTableView);

next usage would be

  1. table->horizontalHeader()->setResizeMode(QHeaderView::Interactive);
  2. table->horizontalHeader()->setStretchLastSection(true);
  3. table->setmodel(model);
  4. table->setSelectionModel(selectionModel);
  5. table->resizeColumnsToContents();

this can go on.. and for my custom objects which have their own functions I will call them in similar fashion. QScopedPointer has functions like isNull, reset etc..
reset will be used only when changing the object..
It doesn’t make more sense to use functions like reset() more than I use my objects functions now does it?
In most of my use cases..Will I be creating more objects using reset() etc and use the objects functions only once/twice or lesser than that? definitely not.

ixSci, can you present evidence of your usage.

January 1, 2011

Volker Volker
Ant Farmer
5428 posts

Ashwin, if Creator would automatically change “table.” to “table->” when typing, you would never be able to write “table.reset()”, because it always would be changed to “table->reset()” even if you try to change it afterwards.

This is in no means related to the frequency you use it, it’s simply that it prevents other things to ever work.

January 1, 2011

Ashwin Das Ashwin Das
Lab Rat
33 posts

Volker, yes I understood that, that is the reason I suggested this in my previous comment –

Ashwin Das wrote:
Yes that makes sense, so it can be such that when I type -, the -> comes up. Which would be easier. Now it is bit complicated. I want it to be easier.

January 1, 2011

Volker Volker
Ant Farmer
5428 posts

Ok, I understood now. I personally do not have a problem with that and do not see much sense in it. But anyways, just open a suggestion ticket on the “bug tracker”: http://bugreports.qt.nokia.com and wait what the trolls will say.

January 1, 2011

Ashwin Das Ashwin Das
Lab Rat
33 posts

Thanks Volker, will do that.

January 1, 2011

Volker Volker
Ant Farmer
5428 posts

And please add the link to the ticket here, once it’s created, so the community can follow.

January 2, 2011

Ashwin Das Ashwin Das
Lab Rat
33 posts
Volker wrote:
And please add the link to the ticket here, once it’s created, so the community can follow.

Link [bugreports.qt.nokia.com]

January 2, 2011

Volker Volker
Ant Farmer
5428 posts

Thanks for the link. It would have been better reported in the Qt Creator Section [bugreports.qt.nokia.com] of the bugtracker, but the Trolls will move it quickly, I’m sure.

January 3, 2011

Andre Andre
Robot Herder
6417 posts

I don’t really like converting the . to a -> for cases where the . would be a valid operator. What would be cool, is if Qt Creator would change the . into a -> if you start typing method names that are not available for the . operator, but are for the -> operator. So, to follow the example given, as soon as you start typing the ‘h’ for horizontal, the . would be changed for a -> as there is no method starting with a h in QScopedPointer itself. However, if you are calling the resizeColumnsToContents() method, that would only happen on when you type the ‘i’, as before that you could have been typing reset() as well, which exists for the . operator.

January 3, 2011

Zlatomir Zlatomir
Hobby Entomologist
366 posts

Yes that would be nice, but we prefer the IDE to be fast, so that we can write code in it, not to look at the “stars” and perform God knows what “calculations” to replace my operators.

//sorry for my little sarcasm ;-)

Guys, we are all programmers, actually i’m not (but i want to become one), so we are programmers that means we know what we want to call and we know if what we call is member of the “smart” pointer or is member of the object pointed to… it not that complicated, and it’s not where most of the typing for an application goes…
And that’s the beauty and power of C++: you are “in command”, you got to know what are you doing, even if Qt simplifies things like memory management, Qt still relies on the strengths and weaknesses of the C++ programming language.

The Trolls did that replacement for “dump” pointers, and it’s ok***, since they are “dump” and don’t have member functions, but for smart-pointers this would be unnecessary, my opinion.

I like Creator because it’s simple and fast, i like VS2010 IDE, but that is slow… and not to mention that Intelisense was the name of the functionality that freeze your IDE to help you write code…
//sarcasm again, Intellisense is not that bad if it’s not exaggerated with a lot of unnecessary features.

***i still consider it “not-so-good” because it might encourage people to confuse pointer with object

Page  
1

  ‹‹ QProgressBar      [Please recommend] Tutorial on how to use Widgets ››

You must log in to post a reply. Not a member yet? Register here!